diff options
author | Chris Lattner <sabre@nondot.org> | 2012-01-31 06:13:55 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2012-01-31 06:13:55 +0000 |
commit | ff8f9ec8336c62b5e3504e2a394f4b25c0cb1963 (patch) | |
tree | c6c339de102a4da0ced97f924199633114d10844 /lib/CodeGen/CodeGenAction.cpp | |
parent | fdba18263ffd624846701ad115d35edb3e2ee0a7 (diff) |
ConstantArray::get() (for strings) is going away, use
ConstantDataArray::getString instead.
Many instances of ConstantArray::get() could be moved to
use more efficient ConstantDataArray methods that avoid a ton
of intermediate Constant*'s for each element (e.g.
GetConstantArrayFromStringLiteral). I don't plan on doing this
in the short-term though.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@149363 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CodeGenAction.cpp')
-rw-r--r-- | lib/CodeGen/CodeGenAction.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/lib/CodeGen/CodeGenAction.cpp b/lib/CodeGen/CodeGenAction.cpp index eedfc57a10..2ac9a6fddf 100644 --- a/lib/CodeGen/CodeGenAction.cpp +++ b/lib/CodeGen/CodeGenAction.cpp @@ -220,18 +220,15 @@ void BackendConsumer::InlineAsmDiagHandler2(const llvm::SMDiagnostic &D, SourceLocation LocCookie) { // There are a couple of different kinds of errors we could get here. First, // we re-format the SMDiagnostic in terms of a clang diagnostic. - - // Strip "error: " off the start of the message string. StringRef Message = D.getMessage(); - if (Message.startswith("error: ")) - Message = Message.substr(7); // If the SMDiagnostic has an inline asm source location, translate it. FullSourceLoc Loc; if (D.getLoc() != SMLoc()) Loc = ConvertBackendLocation(D, Context->getSourceManager()); - + // FIXME: Propagate ranges up as well. + // If this problem has clang-level source location information, report the // issue as being an error in the source with a note showing the instantiated // code. |