diff options
| author | John McCall <rjmccall@apple.com> | 2010-12-04 03:47:34 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-12-04 03:47:34 +0000 |
| commit | f6a1648197562e0b133440d612d9af297d0a86cc (patch) | |
| tree | 10c1ff179182b53e5f8eb356b7fe1ace0c7dab41 /lib/Checker/IdempotentOperationChecker.cpp | |
| parent | e68b9842d2d6adc2c72c81c845a2c68e58d9d3a4 (diff) | |
Although we currently have explicit lvalue-to-rvalue conversions, they're
not actually frequently used, because ImpCastExprToType only creates a node
if the types differ. So explicitly create an ICE in the lvalue-to-rvalue
conversion code in DefaultFunctionArrayLvalueConversion() as well as several
other new places, and consistently deal with the consequences throughout the
compiler.
In addition, introduce a new cast kind for loading an ObjCProperty l-value,
and make sure we emit those nodes whenever an ObjCProperty l-value appears
that's not on the LHS of an assignment operator.
This breaks a couple of rewriter tests, which I've x-failed until future
development occurs on the rewriter.
Ted Kremenek kindly contributed the analyzer workarounds in this patch.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120890 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Checker/IdempotentOperationChecker.cpp')
| -rw-r--r-- | lib/Checker/IdempotentOperationChecker.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/Checker/IdempotentOperationChecker.cpp b/lib/Checker/IdempotentOperationChecker.cpp index 0e23c2a031..245caef485 100644 --- a/lib/Checker/IdempotentOperationChecker.cpp +++ b/lib/Checker/IdempotentOperationChecker.cpp @@ -543,7 +543,7 @@ bool IdempotentOperationChecker::isTruncationExtensionAssignment( if (VD != RHS_DR->getDecl()) return false; - return dyn_cast<DeclRefExpr>(RHS->IgnoreParens()) == NULL; + return dyn_cast<DeclRefExpr>(RHS->IgnoreParenLValueCasts()) == NULL; } // Returns false if a path to this block was not completely analyzed, or true |