diff options
| author | Zhongxing Xu <xuzhongxing@gmail.com> | 2009-12-09 08:32:57 +0000 |
|---|---|---|
| committer | Zhongxing Xu <xuzhongxing@gmail.com> | 2009-12-09 08:32:57 +0000 |
| commit | 2f4a6b25a7409f6f05e8a5e6864de21a337c8958 (patch) | |
| tree | 28c46809e4067feed42c892350032b98cb2f2a4d /lib/Analysis/GRExprEngine.cpp | |
| parent | eac813909b3ca1142ad186f6c6a1b1ae0dbf9378 (diff) | |
OSAtomic simulation: use the original region as the location to load from,
instead of the ElementRegion obtained from casts.
Test cast: the leak cannot occur bacause the true branch cannot be taken.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@90964 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/GRExprEngine.cpp')
| -rw-r--r-- | lib/Analysis/GRExprEngine.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp index 4a960c6937..daa249f901 100644 --- a/lib/Analysis/GRExprEngine.cpp +++ b/lib/Analysis/GRExprEngine.cpp @@ -1483,10 +1483,13 @@ static bool EvalOSAtomicCompareAndSwap(ExplodedNodeSet& Dst, ExplodedNodeSet Tmp; SVal location = state->getSVal(theValueExpr); // Here we should use the value type of the region as the load type. - const MemRegion *R = location.getAsRegion(); + const MemRegion *R = location.getAsRegion()->StripCasts(); QualType LoadTy; - if (R) + if (R) { LoadTy = cast<TypedRegion>(R)->getValueType(C); + // Use the region as the real load location. + location = loc::MemRegionVal(R); + } Engine.EvalLoad(Tmp, theValueExpr, Pred, state, location, OSAtomicLoadTag, LoadTy); |