diff options
| author | Hans Wennborg <hans@hanshq.net> | 2012-03-09 10:10:54 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2012-03-09 10:10:54 +0000 |
| commit | f85626453123f9691bcef13cff963f556e209c27 (patch) | |
| tree | 857081a693269f18da82d7715e2464c994c0ac42 /lib/Analysis/FormatString.cpp | |
| parent | ef9f29804fa8932282a17b414ef0dde2ea4eec03 (diff) | |
-Wformat-non-iso: warn about positional arguments (pr12017)
This renames the -Wformat-non-standard flag to -Wformat-non-iso,
rewords the current warnings a bit (pointing out that a format string
is not supported by ISO C rather than being "non standard"),
and adds a warning about positional arguments.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@152403 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/FormatString.cpp')
| -rw-r--r-- | lib/Analysis/FormatString.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/Analysis/FormatString.cpp b/lib/Analysis/FormatString.cpp index 5785655c94..dd2f2406d4 100644 --- a/lib/Analysis/FormatString.cpp +++ b/lib/Analysis/FormatString.cpp @@ -156,6 +156,9 @@ clang::analyze_format_string::ParseArgPosition(FormatStringHandler &H, } if (Amt.getHowSpecified() == OptionalAmount::Constant && *(I++) == '$') { + // Warn that positional arguments are non-standard. + H.HandlePosition(Start, I - Start); + // Special case: '%0$', since this is an easy mistake. if (Amt.getConstantAmount() == 0) { H.HandleZeroPosition(Start, I - Start); |