Major refactoring/cleanup of GRExprEngine, ExplodedGraph, and BugReporter.

Bugs are now reported using a combination of "BugType" (previously
BugDescription) and Bug "BugReport" objects, which are fed to BugReporter (which
generates PathDiagnostics). This provides a far more modular way of registering
bug types and plugging in diagnostics.

GRExprEngine now owns its copy of GRCoreEngine, and is not owned by the
ExplodedGraph.

ExplodedGraph is no longer templated on the "checker", but instead on the state
contained in the nodes.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49453 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 3 insertions, 11 deletions

diff --git a/include/clang/Analysis/PathSensitive/ExplodedGraph.h b/include/clang/Analysis/PathSensitive/ExplodedGraph.h
index 30d95605ea..8db069639b 100644
--- a/include/clang/Analysis/PathSensitive/ExplodedGraph.h
+++ b/include/clang/Analysis/PathSensitive/ExplodedGraph.h
@@ -278,17 +278,14 @@ public:
   
 };
   
-template <typename CHECKER>
+template <typename STATE>
 class ExplodedGraph : public ExplodedGraphImpl {
 public:
-  typedef CHECKER                     CheckerTy;
-  typedef typename CHECKER::StateTy   StateTy;
+  typedef STATE                       StateTy;
   typedef ExplodedNode<StateTy>       NodeTy;  
   typedef llvm::FoldingSet<NodeTy>    AllNodesTy;
   
 protected:  
-  llvm::OwningPtr<CheckerTy> CheckerState;
-
   /// Nodes - The nodes in the graph.
   AllNodesTy Nodes;
   
@@ -305,12 +302,7 @@ protected:
     
 public:
   ExplodedGraph(CFG& c, Decl& cd, ASTContext& ctx)
-    : ExplodedGraphImpl(c, cd, ctx), CheckerState(new CheckerTy(*this)) {}
-  
-  /// getCheckerState - Returns the internal checker state associated
-  ///  with the exploded graph.  Ownership remains with the ExplodedGraph
-  ///  objecct.
-  CheckerTy* getCheckerState() const { return CheckerState.get(); }
+    : ExplodedGraphImpl(c, cd, ctx) {}
   
   /// getNode - Retrieve the node associated with a (Location,State) pair,
   ///  where the 'Location' is a ProgramPoint in the CFG.  If no node for