aboutsummaryrefslogtreecommitdiff
path: root/CodeGen/CodeGenTypes.cpp
diff options
context:
space:
mode:
authorTed Kremenek <kremenek@apple.com>2007-12-10 23:58:39 +0000
committerTed Kremenek <kremenek@apple.com>2007-12-10 23:58:39 +0000
commit9a8385d6653a50169284fa031be287645ae4b114 (patch)
treea39971ad089bb6828930f9cb02102feea0d7dcd7 /CodeGen/CodeGenTypes.cpp
parent6aad91a43e26118c824d976661077819265d9bc0 (diff)
Fixed bug in CFG::PopulateBlkExprMap where the ordering
between fetching the size of the expression map (for use as the next integer id for an Expr*) and the creation of the entry in the map could be non-deterministic. This could cause the size of the map to be incremented prior to the index being determine. On Linux the map entry would be created first, causing the map to the "size" to be incremented prior to it being queried. On Mac OS X we had the reverse behavior. Now the size is always queried prior to the new id being inserted into the map. This was the real cause of the bit-overrun triggered in PR 1847: http://llvm.org/bugs/show_bug.cgi?id=1847 Also reverted the change in patch 44813, which was a bogus fix to this problem: http://llvm.org/viewvc/llvm-project?rev=44813&view=rev git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@44822 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'CodeGen/CodeGenTypes.cpp')
0 files changed, 0 insertions, 0 deletions