aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2011-03-27 19:53:47 +0000
committerFariborz Jahanian <fjahanian@apple.com>2011-03-27 19:53:47 +0000
commitf2d74cc083e1a83838acf99d2e1ca260d1c54742 (patch)
tree38a24bbe562ebf1eecff1f553fd6fdce51ba8df0
parent4147d307086cf024a40a080e2bf379e9725f6f41 (diff)
'self' is objective-c's 'self' objc pointer only in
an objc method. Fixes // rdar://9181463 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@128389 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaExprObjC.cpp3
-rw-r--r--test/SemaObjC/self-in-function.m23
2 files changed, 26 insertions, 0 deletions
diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp
index 6b6600740f..22a1b19921 100644
--- a/lib/Sema/SemaExprObjC.cpp
+++ b/lib/Sema/SemaExprObjC.cpp
@@ -324,6 +324,9 @@ bool Sema::CheckMessageArgumentTypes(Expr **Args, unsigned NumArgs,
}
bool Sema::isSelfExpr(Expr *RExpr) {
+ // 'self' is objc 'self' in an objc method only.
+ if (!isa<ObjCMethodDecl>(CurContext))
+ return false;
if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(RExpr))
if (ICE->getCastKind() == CK_LValueToRValue)
RExpr = ICE->getSubExpr();
diff --git a/test/SemaObjC/self-in-function.m b/test/SemaObjC/self-in-function.m
new file mode 100644
index 0000000000..901cc31e47
--- /dev/null
+++ b/test/SemaObjC/self-in-function.m
@@ -0,0 +1,23 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// rdar://9181463
+
+typedef struct objc_class *Class;
+
+typedef struct objc_object {
+ Class isa;
+} *id;
+
+@interface NSObject
++ (id) alloc;
+@end
+
+
+void foo(Class self) {
+ [self alloc];
+}
+
+void bar(Class self) {
+ Class y = self;
+ [y alloc];
+}
+