diff options
author | Anders Carlsson <andersca@mac.com> | 2010-05-03 15:09:17 +0000 |
---|---|---|
committer | Anders Carlsson <andersca@mac.com> | 2010-05-03 15:09:17 +0000 |
commit | e99bdb6969ec16d2829ccdf62b04a8c8eda8b215 (patch) | |
tree | 5fe6ca93f5b13089ddaf7ee61a239f22eb34cca9 | |
parent | 33d73fa9dbeddae48cf44a100937b02eae9843c4 (diff) |
Don't build an aggregate constructor loop when the constructor is trivial.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@102912 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/CodeGen/CGExprCXX.cpp | 12 | ||||
-rw-r--r-- | test/CodeGenCXX/new.cpp | 10 |
2 files changed, 17 insertions, 5 deletions
diff --git a/lib/CodeGen/CGExprCXX.cpp b/lib/CodeGen/CGExprCXX.cpp index 149f616bf0..b57cdc9334 100644 --- a/lib/CodeGen/CGExprCXX.cpp +++ b/lib/CodeGen/CGExprCXX.cpp @@ -465,11 +465,13 @@ static void EmitNewInitializer(CodeGenFunction &CGF, const CXXNewExpr *E, llvm::Value *NewPtr, llvm::Value *NumElements) { if (E->isArray()) { - if (CXXConstructorDecl *Ctor = E->getConstructor()) - CGF.EmitCXXAggrConstructorCall(Ctor, NumElements, NewPtr, - E->constructor_arg_begin(), - E->constructor_arg_end()); - return; + if (CXXConstructorDecl *Ctor = E->getConstructor()) { + if (!Ctor->getParent()->hasTrivialConstructor()) + CGF.EmitCXXAggrConstructorCall(Ctor, NumElements, NewPtr, + E->constructor_arg_begin(), + E->constructor_arg_end()); + return; + } } QualType AllocType = E->getAllocatedType(); diff --git a/test/CodeGenCXX/new.cpp b/test/CodeGenCXX/new.cpp index cc6288575b..885158f8a0 100644 --- a/test/CodeGenCXX/new.cpp +++ b/test/CodeGenCXX/new.cpp @@ -96,3 +96,13 @@ void t11() { // CHECK: call void @llvm.memset.p0i8.i64( B* b = new B(); } + +struct Empty { }; + +// We don't need to initialize an empty class. +void t12() { + // CHECK: define void @_Z3t12v + // CHECK-NOT: br label + // CHECK: ret void + (void)new Empty[10]; +} |