diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2009-05-05 18:34:37 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2009-05-05 18:34:37 +0000 |
| commit | 041f2fd6237c7ce72864e42c66c6b12b52f35f9c (patch) | |
| tree | 099afdf370bfdfa7cf238579158650761fd01905 | |
| parent | b0ed3029d96e31dfa71a61ac5aa8d04710e0fb12 (diff) | |
Issue a warning in odd case of instance method used
in a 'Class' receiver which is not a root instance
method.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@70987 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/DiagnosticSemaKinds.td | 2 | ||||
| -rw-r--r-- | lib/Sema/SemaExprObjC.cpp | 9 | ||||
| -rw-r--r-- | test/SemaObjC/inst-method-lookup-in-root.m | 27 |
3 files changed, 38 insertions, 0 deletions
diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index 334b6badca..277395cd7e 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -1096,6 +1096,8 @@ def ext_freestanding_complex : Extension< // Obj-c expressions +def warn_root_inst_method_not_found : Warning< + "instance method %0 is being used on 'Class' which is not in the root class">; def warn_class_method_not_found : Warning< "method %objcclass0 not found (return type defaults to 'id')">; def warn_inst_method_not_found : Warning< diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index a463ab8f83..e8ff18ba0c 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -529,8 +529,17 @@ Sema::ExprResult Sema::ActOnInstanceMessage(ExprTy *receiver, Selector Sel, if (!isSelfExpr(RExpr)) { Method = LookupFactoryMethodInGlobalPool(Sel, SourceRange(lbrac,rbrac)); if (!Method) { + // If no class (factory) method was found, check if an _instance_ + // method of the same name exists in the root class only. Method = LookupInstanceMethodInGlobalPool( Sel, SourceRange(lbrac,rbrac)); + if (Method) + if (const ObjCInterfaceDecl *ID = + dyn_cast<ObjCInterfaceDecl>(Method->getDeclContext())) { + if (ID->getSuperClass()) + Diag(lbrac, diag::warn_root_inst_method_not_found) + << Sel << SourceRange(lbrac, rbrac); + } } } } diff --git a/test/SemaObjC/inst-method-lookup-in-root.m b/test/SemaObjC/inst-method-lookup-in-root.m new file mode 100644 index 0000000000..93f28e69f9 --- /dev/null +++ b/test/SemaObjC/inst-method-lookup-in-root.m @@ -0,0 +1,27 @@ +// RUN: clang-cc -fsyntax-only -verify %s + +@protocol P +- (id) inst_in_proto; +@end + +@interface Object <P> +- (id) inst_in_root; +@end + +@interface Base +@end + +@interface Derived: Base +- (id)starboard; +@end + +void foo(void) { + Class receiver; + + [Derived starboard]; // expected-warning {{method '+starboard' not found}} + + [receiver starboard]; // expected-warning {{instance method 'starboard' is being used on 'Class'}} + [receiver inst_in_root]; // Ok! + [receiver inst_in_proto]; // Ok! +} + |