aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2010-03-22 21:08:50 +0000
committerChris Lattner <sabre@nondot.org>2010-03-22 21:08:50 +0000
commit3c989027f68e2d9dfd57c018ccc550bd9fb79920 (patch)
tree60724824505b72e3177d80898c8800b48e6bd300
parenta87d477c69ec31a0d24b7c53e4a781fb76617809 (diff)
(re)implement PR6542, accepting and discarding the __gcc_tdiag__
format attribute specifier. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@99213 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaDeclAttr.cpp8
-rw-r--r--test/Sema/attr-format.c4
2 files changed, 12 insertions, 0 deletions
diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp
index 73a34f8107..5a7a3c31fe 100644
--- a/lib/Sema/SemaDeclAttr.cpp
+++ b/lib/Sema/SemaDeclAttr.cpp
@@ -1115,6 +1115,7 @@ enum FormatAttrKind {
NSStringFormat,
StrftimeFormat,
SupportedFormat,
+ IgnoredFormat,
InvalidFormat
};
@@ -1136,6 +1137,9 @@ static FormatAttrKind getFormatAttrKind(llvm::StringRef Format) {
Format == "zcmn_err")
return SupportedFormat;
+ if (Format == "gcc_tdiag")
+ return IgnoredFormat;
+
return InvalidFormat;
}
@@ -1171,6 +1175,10 @@ static void HandleFormatAttr(Decl *d, const AttributeList &Attr, Sema &S) {
// Check for supported formats.
FormatAttrKind Kind = getFormatAttrKind(Format);
+
+ if (Kind == IgnoredFormat)
+ return;
+
if (Kind == InvalidFormat) {
S.Diag(Attr.getLoc(), diag::warn_attribute_type_not_supported)
<< "format" << Attr.getParameterName()->getName();
diff --git a/test/Sema/attr-format.c b/test/Sema/attr-format.c
index 594e590e6b..34102c6603 100644
--- a/test/Sema/attr-format.c
+++ b/test/Sema/attr-format.c
@@ -68,3 +68,7 @@ void __attribute__((format(printf, 1, 0)))
foo2(const char *fmt, va_list va) {
xx_vprintf(foo(fmt), va);
}
+
+// PR6542
+extern void gcc_format (const char *, ...)
+ __attribute__ ((__format__(__gcc_tdiag__, 1, 2)));