diff options
| author | Chris Lattner <sabre@nondot.org> | 2008-07-21 04:42:08 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2008-07-21 04:42:08 +0000 |
| commit | 1f719747b214866535e63b0fe2f5f21da67a5387 (patch) | |
| tree | cdf7d14294e172c7ae4b294df646adaa2e7384bf | |
| parent | 68a057b4292f5ff814ec8da53f6cda8cdcfbd2ae (diff) | |
improve the diagnostic for an erroneous objc ivar reference
from:
t.m:8:7: error: member reference is not to a structure or union
pool->farm = 0;
^ ~~~~
to:
t.m:8:7: error: 'NSAutoreleasePool' has member named 'farm'
pool->farm = 0;
~~~~^ ~~~~
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@53824 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/DiagnosticKinds.def | 2 | ||||
| -rw-r--r-- | lib/Sema/SemaExpr.cpp | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/include/clang/Basic/DiagnosticKinds.def b/include/clang/Basic/DiagnosticKinds.def index ee8e33439a..b17102dede 100644 --- a/include/clang/Basic/DiagnosticKinds.def +++ b/include/clang/Basic/DiagnosticKinds.def @@ -881,6 +881,8 @@ DIAG(err_typecheck_subscript_not_object, ERROR, "illegal subscript of non-object type '%0'") DIAG(err_typecheck_member_reference_structUnion, ERROR, "member reference is not to a structure or union") +DIAG(err_typecheck_member_reference_ivar, ERROR, + "'%0' has member named '%1'") DIAG(err_typecheck_member_reference_arrow, ERROR, "member reference is not a pointer") DIAG(err_typecheck_incomplete_tag, ERROR, diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index 7babcf9d4f..b81e090f7f 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -622,8 +622,9 @@ ActOnMemberReferenceExpr(ExprTy *Base, SourceLocation OpLoc, if (ObjCIvarDecl *IV = IFTy->getDecl()->lookupInstanceVariable(&Member)) return new ObjCIvarRefExpr(IV, IV->getType(), MemberLoc, BaseExpr, OpKind == tok::arrow); - return Diag(OpLoc, diag::err_typecheck_member_reference_structUnion, - SourceRange(MemberLoc)); + return Diag(OpLoc, diag::err_typecheck_member_reference_ivar, + IFTy->getDecl()->getName(), Member.getName(), + BaseExpr->getSourceRange(), SourceRange(MemberLoc)); } // Handle property access. |