diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2011-09-07 05:01:10 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2011-09-07 05:01:10 +0000 |
| commit | 0580e7dccecadc8edee3ed47fe22283addf92e2b (patch) | |
| tree | bce542cd275a2f1e648acabff439bce8768cc783 | |
| parent | 900693b715b3832a42ae87157332baece94ccdd8 (diff) | |
Don't compute the same line number in two places, once inside a loop.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@139225 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Frontend/TextDiagnosticPrinter.cpp | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/lib/Frontend/TextDiagnosticPrinter.cpp b/lib/Frontend/TextDiagnosticPrinter.cpp index 51ecc2657d..100362f773 100644 --- a/lib/Frontend/TextDiagnosticPrinter.cpp +++ b/lib/Frontend/TextDiagnosticPrinter.cpp @@ -505,6 +505,7 @@ public: if (Invalid) return; + unsigned LineNo = SM.getLineNumber(FID, FileOffset); unsigned ColNo = SM.getColumnNumber(FID, FileOffset); unsigned CaretEndColNo = ColNo + Lexer::MeasureTokenLength(Loc, SM, LangOpts); @@ -533,14 +534,10 @@ public: std::string CaretLine(LineEnd-LineStart, ' '); // Highlight all of the characters covered by Ranges with ~ characters. - if (!Ranges.empty()) { - unsigned LineNo = SM.getLineNumber(FID, FileOffset); - - for (SmallVectorImpl<CharSourceRange>::iterator I = Ranges.begin(), - E = Ranges.end(); - I != E; ++I) - Printer.HighlightRange(*I, SM, LineNo, FID, CaretLine, SourceLine); - } + for (SmallVectorImpl<CharSourceRange>::iterator I = Ranges.begin(), + E = Ranges.end(); + I != E; ++I) + Printer.HighlightRange(*I, SM, LineNo, FID, CaretLine, SourceLine); // Next, insert the caret itself. if (ColNo-1 < CaretLine.size()) @@ -579,7 +576,7 @@ public: CaretLine = ' ' + CaretLine; } - std::string FixItInsertionLine = BuildFixItInsertionLine(FID, FileOffset, + std::string FixItInsertionLine = BuildFixItInsertionLine(LineNo, LineStart, LineEnd, Hints); @@ -618,7 +615,7 @@ public: } private: - std::string BuildFixItInsertionLine(FileID FID, unsigned FileOffset, + std::string BuildFixItInsertionLine(unsigned LineNo, const char *LineStart, const char *LineEnd, ArrayRef<FixItHint> Hints) { @@ -633,8 +630,7 @@ private: // code is on the same line as the caret. std::pair<FileID, unsigned> HintLocInfo = SM.getDecomposedExpansionLoc(I->RemoveRange.getBegin()); - if (SM.getLineNumber(HintLocInfo.first, HintLocInfo.second) == - SM.getLineNumber(FID, FileOffset)) { + if (LineNo == SM.getLineNumber(HintLocInfo.first, HintLocInfo.second)) { // Insert the new code into the line just below the code // that the user wrote. unsigned HintColNo |