aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2012-05-10 03:01:34 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2012-05-10 03:01:34 +0000
commitdd44f34301316b814277d6a8c146d86c7115330b (patch)
tree9831fd8b2c2bfb537e2f732e360149b1f82d8aea
parent98ae834a3e289f84f0765d0d0ca7ff22ccaba458 (diff)
Warn about visibility attributes in typedefs.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@156534 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaDeclAttr.cpp4
-rw-r--r--test/Sema/attr-visibility.c2
2 files changed, 6 insertions, 0 deletions
diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp
index 280e3d7fca..9cd72b2e1e 100644
--- a/lib/Sema/SemaDeclAttr.cpp
+++ b/lib/Sema/SemaDeclAttr.cpp
@@ -1857,6 +1857,10 @@ static void handleAvailabilityAttr(Sema &S, Decl *D,
bool Sema::mergeVisibilityAttr(Decl *D, SourceRange Range,
bool Inherited,
VisibilityAttr::VisibilityType Vis) {
+ if (isa<TypedefNameDecl>(D)) {
+ Diag(Range.getBegin(), diag::warn_attribute_ignored) << "visibility";
+ return false;
+ }
VisibilityAttr *ExistingAttr = D->getAttr<VisibilityAttr>();
if (ExistingAttr) {
VisibilityAttr::VisibilityType ExistingVis = ExistingAttr->getVisibility();
diff --git a/test/Sema/attr-visibility.c b/test/Sema/attr-visibility.c
index cc3c54a047..77bc39c9e6 100644
--- a/test/Sema/attr-visibility.c
+++ b/test/Sema/attr-visibility.c
@@ -20,3 +20,5 @@ void test6() __attribute__((visibility("hidden"), // expected-note {{previous at
extern int test7 __attribute__((visibility("default"))); // expected-note {{previous attribute is here}}
extern int test7 __attribute__((visibility("hidden"))); // expected-error {{visibility does not match previous declaration}}
+
+typedef int __attribute__((visibility("default"))) bar; // expected-warning {{visibility attribute ignored}}