aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2011-03-28 16:23:34 +0000
committerFariborz Jahanian <fjahanian@apple.com>2011-03-28 16:23:34 +0000
commitb460210fe0dec08971edfe33c294323cf79cb894 (patch)
tree945e7e4c3bca4c33f1df0719434b8363263d16bb
parent7f3ad231bed2184694e407772689e8903068bdca (diff)
Also 'self' in blocks need be handled specially.
// rdar://9181463 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@128410 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaExprObjC.cpp5
-rw-r--r--test/SemaObjC/self-in-function.m5
2 files changed, 8 insertions, 2 deletions
diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp
index 22a1b19921..cf38225de0 100644
--- a/lib/Sema/SemaExprObjC.cpp
+++ b/lib/Sema/SemaExprObjC.cpp
@@ -325,7 +325,10 @@ bool Sema::CheckMessageArgumentTypes(Expr **Args, unsigned NumArgs,
bool Sema::isSelfExpr(Expr *RExpr) {
// 'self' is objc 'self' in an objc method only.
- if (!isa<ObjCMethodDecl>(CurContext))
+ DeclContext *DC = CurContext;
+ while (isa<BlockDecl>(DC))
+ DC = DC->getParent();
+ if (DC && !isa<ObjCMethodDecl>(DC))
return false;
if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(RExpr))
if (ICE->getCastKind() == CK_LValueToRValue)
diff --git a/test/SemaObjC/self-in-function.m b/test/SemaObjC/self-in-function.m
index 901cc31e47..9027a947a0 100644
--- a/test/SemaObjC/self-in-function.m
+++ b/test/SemaObjC/self-in-function.m
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsyntax-only -fblocks -verify %s
// rdar://9181463
typedef struct objc_class *Class;
@@ -14,6 +14,9 @@ typedef struct objc_object {
void foo(Class self) {
[self alloc];
+ (^() {
+ [self alloc];
+ })();
}
void bar(Class self) {