diff options
| author | Peter Collingbourne <peter@pcc.me.uk> | 2011-09-20 12:40:26 +0000 |
|---|---|---|
| committer | Peter Collingbourne <peter@pcc.me.uk> | 2011-09-20 12:40:26 +0000 |
| commit | 8be0c74e4a779b13c2d8fd8482dcd438eeb089d3 (patch) | |
| tree | 955900e6577cf98ca70de0491ae22b33c6673f04 | |
| parent | 9d8c2b61519cb05ac6737cc542e274f9e2e0552a (diff) | |
Remove redundant break statements, and replace asserts with llvm_unreachable
Per John's review comments for r140068.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@140142 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/AST/Decl.cpp | 14 | ||||
| -rw-r--r-- | lib/Sema/SemaDecl.cpp | 3 |
2 files changed, 8 insertions, 9 deletions
diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp index 4aa1d22be0..73a6558e10 100644 --- a/lib/AST/Decl.cpp +++ b/lib/AST/Decl.cpp @@ -1120,15 +1120,15 @@ QualifierInfo::setTemplateParameterListsInfo(ASTContext &Context, const char *VarDecl::getStorageClassSpecifierString(StorageClass SC) { switch (SC) { case SC_None: break; - case SC_Auto: return "auto"; break; - case SC_Extern: return "extern"; break; - case SC_OpenCLWorkGroupLocal: return "<<work-group-local>>"; break; - case SC_PrivateExtern: return "__private_extern__"; break; - case SC_Register: return "register"; break; - case SC_Static: return "static"; break; + case SC_Auto: return "auto"; + case SC_Extern: return "extern"; + case SC_OpenCLWorkGroupLocal: return "<<work-group-local>>"; + case SC_PrivateExtern: return "__private_extern__"; + case SC_Register: return "register"; + case SC_Static: return "static"; } - assert(0 && "Invalid storage class"); + llvm_unreachable("Invalid storage class"); return 0; } diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index 52a05db7cf..6ad8584469 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -6148,8 +6148,7 @@ void Sema::ActOnCXXForRangeDecl(Decl *D) { Error = 4; break; case SC_OpenCLWorkGroupLocal: - assert(0 && "Unexpected storage class"); - break; + llvm_unreachable("Unexpected storage class"); } // FIXME: constexpr isn't allowed here. //if (DS.isConstexprSpecified()) |