aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitri Gribenko <gribozavr@gmail.com>2012-07-13 19:02:42 +0000
committerDmitri Gribenko <gribozavr@gmail.com>2012-07-13 19:02:42 +0000
commit0eaf69d9a10149f0f344238183915912c2dca392 (patch)
tree6d412a89fa5a93006c0379c70683046e724bf372
parent6b60370ddb5b63e93f25dfbed920be0f335ddad3 (diff)
Comment AST nodes: rename getXXXCount() methods to getNumXXXs() to be in line with Statement AST nodes.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@160182 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/clang/AST/Comment.h10
-rw-r--r--lib/AST/CommentDumper.cpp6
-rw-r--r--lib/AST/CommentSema.cpp6
-rw-r--r--unittests/AST/CommentParser.cpp30
4 files changed, 26 insertions, 26 deletions
diff --git a/include/clang/AST/Comment.h b/include/clang/AST/Comment.h
index 8710f45bf0..a397703513 100644
--- a/include/clang/AST/Comment.h
+++ b/include/clang/AST/Comment.h
@@ -242,7 +242,7 @@ public:
getLocEnd());
}
- unsigned getArgCount() const {
+ unsigned getNumArgs() const {
return Args.size();
}
@@ -354,7 +354,7 @@ public:
child_iterator child_end() const { return NULL; }
- unsigned getAttrCount() const {
+ unsigned getNumAttrs() const {
return Attributes.size();
}
@@ -532,7 +532,7 @@ public:
getLocStart().getLocWithOffset(1 + Name.size()));
}
- unsigned getArgCount() const {
+ unsigned getNumArgs() const {
return Args.size();
}
@@ -611,7 +611,7 @@ public:
}
bool hasParamName() const {
- return getArgCount() > 0;
+ return getNumArgs() > 0;
}
StringRef getParamName() const {
@@ -708,7 +708,7 @@ public:
return CloseName;
}
- unsigned getLineCount() const {
+ unsigned getNumLines() const {
return Lines.size();
}
diff --git a/lib/AST/CommentDumper.cpp b/lib/AST/CommentDumper.cpp
index 7ff61e0a27..7a075a6748 100644
--- a/lib/AST/CommentDumper.cpp
+++ b/lib/AST/CommentDumper.cpp
@@ -106,7 +106,7 @@ void CommentDumper::visitTextComment(const TextComment *C) {
void CommentDumper::visitInlineCommandComment(const InlineCommandComment *C) {
dumpComment(C);
- for (unsigned i = 0, e = C->getArgCount(); i != e; ++i)
+ for (unsigned i = 0, e = C->getNumArgs(); i != e; ++i)
OS << " Arg[" << i << "]=\"" << C->getArgText(i) << "\"";
}
@@ -114,9 +114,9 @@ void CommentDumper::visitHTMLStartTagComment(const HTMLStartTagComment *C) {
dumpComment(C);
OS << " Name=\"" << C->getTagName() << "\"";
- if (C->getAttrCount() != 0) {
+ if (C->getNumAttrs() != 0) {
OS << " Attrs: ";
- for (unsigned i = 0, e = C->getAttrCount(); i != e; ++i) {
+ for (unsigned i = 0, e = C->getNumAttrs(); i != e; ++i) {
const HTMLStartTagComment::Attribute &Attr = C->getAttr(i);
OS << " \"" << Attr.Name << "=\"" << Attr.Value << "\"";
}
diff --git a/lib/AST/CommentSema.cpp b/lib/AST/CommentSema.cpp
index 955629c658..6a8b32cee3 100644
--- a/lib/AST/CommentSema.cpp
+++ b/lib/AST/CommentSema.cpp
@@ -130,7 +130,7 @@ ParamCommandComment *Sema::actOnParamCommandParamNameArg(
SourceLocation ArgLocEnd,
StringRef Arg) {
// Parser will not feed us more arguments than needed.
- assert(Command->getArgCount() == 0);
+ assert(Command->getNumArgs() == 0);
if (!Command->isDirectionExplicit()) {
// User didn't provide a direction argument.
@@ -362,8 +362,8 @@ void Sema::checkBlockCommandEmptyParagraph(BlockCommandComment *Command) {
ParagraphComment *Paragraph = Command->getParagraph();
if (Paragraph->isWhitespace()) {
SourceLocation DiagLoc;
- if (Command->getArgCount() > 0)
- DiagLoc = Command->getArgRange(Command->getArgCount() - 1).getEnd();
+ if (Command->getNumArgs() > 0)
+ DiagLoc = Command->getArgRange(Command->getNumArgs() - 1).getEnd();
if (!DiagLoc.isValid())
DiagLoc = Command->getCommandNameRange().getEnd();
Diag(DiagLoc, diag::warn_doc_block_command_empty_paragraph)
diff --git a/unittests/AST/CommentParser.cpp b/unittests/AST/CommentParser.cpp
index d2f87488de..cc9ed9c4cc 100644
--- a/unittests/AST/CommentParser.cpp
+++ b/unittests/AST/CommentParser.cpp
@@ -244,9 +244,9 @@ struct NoArgs {};
if (!AR)
return AR;
- if (ICC->getArgCount() != 0)
+ if (ICC->getNumArgs() != 0)
return ::testing::AssertionFailure()
- << "InlineCommandComment has " << ICC->getArgCount() << " arg(s), "
+ << "InlineCommandComment has " << ICC->getNumArgs() << " arg(s), "
"expected 0";
return ::testing::AssertionSuccess();
@@ -261,9 +261,9 @@ struct NoArgs {};
if (!AR)
return AR;
- if (ICC->getArgCount() != 1)
+ if (ICC->getNumArgs() != 1)
return ::testing::AssertionFailure()
- << "InlineCommandComment has " << ICC->getArgCount() << " arg(s), "
+ << "InlineCommandComment has " << ICC->getNumArgs() << " arg(s), "
"expected 1";
StringRef ActualArg = ICC->getArgText(0);
@@ -326,9 +326,9 @@ struct NoAttrs {};
return ::testing::AssertionFailure()
<< "HTMLStartTagComment is self-closing";
- if (HST->getAttrCount() != 0)
+ if (HST->getNumAttrs() != 0)
return ::testing::AssertionFailure()
- << "HTMLStartTagComment has " << HST->getAttrCount() << " attr(s), "
+ << "HTMLStartTagComment has " << HST->getNumAttrs() << " attr(s), "
"expected 0";
return ::testing::AssertionSuccess();
@@ -348,9 +348,9 @@ struct NoAttrs {};
return ::testing::AssertionFailure()
<< "HTMLStartTagComment is self-closing";
- if (HST->getAttrCount() != 1)
+ if (HST->getNumAttrs() != 1)
return ::testing::AssertionFailure()
- << "HTMLStartTagComment has " << HST->getAttrCount() << " attr(s), "
+ << "HTMLStartTagComment has " << HST->getNumAttrs() << " attr(s), "
"expected 1";
StringRef ActualName = HST->getAttr(0).Name;
@@ -413,9 +413,9 @@ struct NoLines {};
if (!AR)
return AR;
- if (VBC->getLineCount() != 0)
+ if (VBC->getNumLines() != 0)
return ::testing::AssertionFailure()
- << "VerbatimBlockComment has " << VBC->getLineCount() << " lines(s), "
+ << "VerbatimBlockComment has " << VBC->getNumLines() << " lines(s), "
"expected 0";
return ::testing::AssertionSuccess();
@@ -430,9 +430,9 @@ struct NoLines {};
if (!AR)
return AR;
- if (VBC->getLineCount() != 1)
+ if (VBC->getNumLines() != 1)
return ::testing::AssertionFailure()
- << "VerbatimBlockComment has " << VBC->getLineCount() << " lines(s), "
+ << "VerbatimBlockComment has " << VBC->getNumLines() << " lines(s), "
"expected 1";
StringRef ActualLine0 = VBC->getText(0);
@@ -454,9 +454,9 @@ struct NoLines {};
if (!AR)
return AR;
- if (VBC->getLineCount() != 2)
+ if (VBC->getNumLines() != 2)
return ::testing::AssertionFailure()
- << "VerbatimBlockComment has " << VBC->getLineCount() << " lines(s), "
+ << "VerbatimBlockComment has " << VBC->getNumLines() << " lines(s), "
"expected 2";
StringRef ActualLine0 = VBC->getText(0);
@@ -1110,7 +1110,7 @@ TEST_F(CommentParserTest, VerbatimBlock6) {
{
VerbatimBlockComment *VBC;
ASSERT_TRUE(HasVerbatimBlockAt(FC, 1, VBC, "verbatim"));
- ASSERT_EQ(4U, VBC->getLineCount());
+ ASSERT_EQ(4U, VBC->getNumLines());
ASSERT_EQ(" Aaa", VBC->getText(0));
ASSERT_EQ("", VBC->getText(1));
ASSERT_EQ(" Bbb", VBC->getText(2));