aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEli Friedman <eli.friedman@gmail.com>2008-05-25 14:03:31 +0000
committerEli Friedman <eli.friedman@gmail.com>2008-05-25 14:03:31 +0000
commitf84eda37251c679e2f20343c47a4a3586d9a8e21 (patch)
tree4bf3759653ec452cf59250215a7ec977acc7f5da
parent402256fc665ba179873ffcb4d630e28cbea42f27 (diff)
Count the number of initializable members correctly in structs/unions
with unnamed members. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51557 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Sema/SemaInit.cpp8
-rw-r--r--test/Sema/array-init.c6
2 files changed, 12 insertions, 2 deletions
diff --git a/lib/Sema/SemaInit.cpp b/lib/Sema/SemaInit.cpp
index 6eb072eeba..43adc2a82f 100644
--- a/lib/Sema/SemaInit.cpp
+++ b/lib/Sema/SemaInit.cpp
@@ -38,9 +38,13 @@ int InitListChecker::numArrayElements(QualType DeclType) {
int InitListChecker::numStructUnionElements(QualType DeclType) {
RecordDecl *structDecl = DeclType->getAsRecordType()->getDecl();
+ int InitializableMembers = 0;
+ for (int i = 0; i < structDecl->getNumMembers(); i++)
+ if (structDecl->getMember(i)->getIdentifier())
+ ++InitializableMembers;
if (structDecl->getKind() == Decl::Union)
- return std::min(structDecl->getNumMembers(), 1);
- return structDecl->getNumMembers() - structDecl->hasFlexibleArrayMember();
+ return std::min(InitializableMembers, 1);
+ return InitializableMembers - structDecl->hasFlexibleArrayMember();
}
void InitListChecker::CheckImplicitInitList(InitListExpr *ParentIList,
diff --git a/test/Sema/array-init.c b/test/Sema/array-init.c
index 69255569dd..c1a789ea5b 100644
--- a/test/Sema/array-init.c
+++ b/test/Sema/array-init.c
@@ -216,3 +216,9 @@ void varArray() {
// PR2151
int emptyInit() {struct {} x[] = {6};} //expected-warning{{empty struct extension}} expected-error{{initializer for aggregate with no elements}}
+int noNamedInit() {
+struct {int:5;} x[] = {6}; //expected-error{{initializer for aggregate with no elements}}
+}
+struct {int a; int:5;} noNamedImplicit[] = {1,2,3};
+int noNamedImplicitCheck[sizeof(noNamedImplicit) == 3 * sizeof(*noNamedImplicit) ? 1 : -1];
+