diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2011-08-02 18:05:30 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2011-08-02 18:05:30 +0000 |
| commit | aebab72698ce5283395e61597a266fb04e62e390 (patch) | |
| tree | a34c5326d8430a8f8796ba8098b3c3e133336b6d | |
| parent | 2b81910618f63e4ce2373c926a26e76b4b91373f (diff) | |
PR10566: Make sure codegen for deleting an pointer to an incomplete type actually works.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@136703 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/CodeGen/CGExprCXX.cpp | 2 | ||||
| -rw-r--r-- | test/CodeGenCXX/delete.cpp | 8 |
2 files changed, 6 insertions, 4 deletions
diff --git a/lib/CodeGen/CGExprCXX.cpp b/lib/CodeGen/CGExprCXX.cpp index 7967c822b3..738aac2595 100644 --- a/lib/CodeGen/CGExprCXX.cpp +++ b/lib/CodeGen/CGExprCXX.cpp @@ -1206,7 +1206,7 @@ static void EmitObjectDelete(CodeGenFunction &CGF, const CXXDestructorDecl *Dtor = 0; if (const RecordType *RT = ElementType->getAs<RecordType>()) { CXXRecordDecl *RD = cast<CXXRecordDecl>(RT->getDecl()); - if (!RD->hasTrivialDestructor()) { + if (RD->hasDefinition() && !RD->hasTrivialDestructor()) { Dtor = RD->getDestructor(); if (Dtor->isVirtual()) { diff --git a/test/CodeGenCXX/delete.cpp b/test/CodeGenCXX/delete.cpp index dbef6a0ebc..8ad76f8532 100644 --- a/test/CodeGenCXX/delete.cpp +++ b/test/CodeGenCXX/delete.cpp @@ -125,9 +125,11 @@ namespace test4 { namespace test5 { struct Incomplete; - // CHECK: define void @_ZN5test523array_delete_incompleteEPNS_10IncompleteE - void array_delete_incomplete(Incomplete *p) { + // CHECK: define void @_ZN5test523array_delete_incompleteEPNS_10IncompleteES1_ + void array_delete_incomplete(Incomplete *p1, Incomplete *p2) { + // CHECK: call void @_ZdlPv + delete p1; // CHECK: call void @_ZdaPv - delete [] p; + delete [] p2; } } |