diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2010-02-19 18:30:30 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2010-02-19 18:30:30 +0000 |
| commit | 354095c29ef10d4763ec079fde4d6f73841152f6 (patch) | |
| tree | 0cd9f6650bb342b8274a962e33344f7e539fa107 | |
| parent | 473d7019bb54f8a2f0140dca9e9644a935cc6b20 (diff) | |
Issue extended diagnostic when property dot-syntax is used and
there is a setter but no getter (part of radar 7664555).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@96687 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/DiagnosticSemaKinds.td | 2 | ||||
| -rw-r--r-- | lib/Sema/SemaExpr.cpp | 11 | ||||
| -rw-r--r-- | test/SemaObjC/property-user-setter.m | 4 |
3 files changed, 11 insertions, 6 deletions
diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index 52d4dd26ff..a8b295abb2 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -2704,6 +2704,8 @@ def ext_c99_array_usage : Extension< def err_c99_array_usage_cxx : Error< "C99-specific array features are not permitted in C++">; +def note_getter_unavailable : Note< + "or because setter is declared here, but no getter method %0 is found">; def err_invalid_protocol_qualifiers : Error< "invalid protocol qualifiers on non-ObjC type">; def warn_ivar_use_hidden : Warning< diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index e950be0485..b3bb7dc7d5 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -3147,9 +3147,12 @@ Sema::LookupMemberExpr(LookupResult &R, Expr *&BaseExpr, return LookupMemberExpr(Res, BaseExpr, IsArrow, OpLoc, SS, ObjCImpDecl); } - - return ExprError(Diag(MemberLoc, diag::err_property_not_found) - << MemberName << BaseType); + Diag(MemberLoc, diag::err_property_not_found) + << MemberName << BaseType; + if (Setter && !Getter) + Diag(Setter->getLocation(), diag::note_getter_unavailable) + << MemberName << BaseExpr->getSourceRange(); + return ExprError(); } // Handle the following exceptional case (*Obj).isa. @@ -3168,7 +3171,7 @@ Sema::LookupMemberExpr(LookupResult &R, Expr *&BaseExpr, return Owned(new (Context) ExtVectorElementExpr(ret, BaseExpr, *Member, MemberLoc)); } - + Diag(MemberLoc, diag::err_typecheck_member_reference_struct_union) << BaseType << BaseExpr->getSourceRange(); diff --git a/test/SemaObjC/property-user-setter.m b/test/SemaObjC/property-user-setter.m index babccee4a7..9479bc6a73 100644 --- a/test/SemaObjC/property-user-setter.m +++ b/test/SemaObjC/property-user-setter.m @@ -70,7 +70,7 @@ static int g_val; { int setterOnly; } -- (void) setSetterOnly:(int)value; +- (void) setSetterOnly:(int)value; // expected-note {{or because setter is declared here, but no getter method 'setterOnly' is found}} @end @implementation Subclass @@ -82,7 +82,7 @@ static int g_val; @interface C {} // - (int)Foo; -- (void)setFoo:(int)value; +- (void)setFoo:(int)value; // expected-note 2 {{or because setter is declared here, but no getter method 'Foo' is found}} @end void g(int); |