diff options
| author | Douglas Gregor <dgregor@apple.com> | 2009-05-18 21:08:14 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2009-05-18 21:08:14 +0000 |
| commit | 2f2433f2c4965640e3eea62c87deb7292492b10f (patch) | |
| tree | f588d5afa5e57a6261deeacbb5e28cbcb772c464 | |
| parent | 725165f2846bd37d3aaf863747fa30126992085e (diff) | |
Deal with an icky corner case where we were complaining that a catch
statement was using an rvalue reference during the template
definition. However, template instantiations based on an lvalue
reference type are well-formed, so we delay checking of these property
until template instantiation time.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72041 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Sema/SemaDeclCXX.cpp | 2 | ||||
| -rw-r--r-- | test/SemaTemplate/instantiate-try-catch.cpp | 14 |
2 files changed, 15 insertions, 1 deletions
diff --git a/lib/Sema/SemaDeclCXX.cpp b/lib/Sema/SemaDeclCXX.cpp index d968bc6b75..78123015a3 100644 --- a/lib/Sema/SemaDeclCXX.cpp +++ b/lib/Sema/SemaDeclCXX.cpp @@ -2553,7 +2553,7 @@ VarDecl *Sema::BuildExceptionDeclaration(Scope *S, QualType ExDeclType, // The exception-declaration shall not denote a pointer or reference to an // incomplete type, other than [cv] void*. // N2844 forbids rvalue references. - if(ExDeclType->isRValueReferenceType()) { + if(!ExDeclType->isDependentType() && ExDeclType->isRValueReferenceType()) { Diag(Loc, diag::err_catch_rvalue_ref) << Range; Invalid = true; } diff --git a/test/SemaTemplate/instantiate-try-catch.cpp b/test/SemaTemplate/instantiate-try-catch.cpp new file mode 100644 index 0000000000..074afa9d17 --- /dev/null +++ b/test/SemaTemplate/instantiate-try-catch.cpp @@ -0,0 +1,14 @@ +// RUN: clang-cc -fsyntax-only -std=c++0x -verify %s + +template<typename T> struct TryCatch0 { + void f() { + try { + } catch (T&&) { // expected-error 2{{cannot catch exceptions by rvalue reference}} + } + } +}; + +template struct TryCatch0<int&>; // okay +template struct TryCatch0<int&&>; // expected-note{{instantiation}} +template struct TryCatch0<int>; // expected-note{{instantiation}} + |