diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-04-25 22:26:58 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-04-25 22:26:58 +0000 |
| commit | 3b5cccad43000e2c0bae52e6ec992a9fa1900266 (patch) | |
| tree | d8e21b3bfdbcc1b5e40a3a6a146ded7ad3e12978 | |
| parent | 617bd458600c6d68ffbe1328806b58384bde848a (diff) | |
Make VerifyIntegerConstantExpr print extension warnings for non-ICEs.
Overall, I'm not particularly happy with the current situation regarding
constant expression diagnostics, but I plan to improve it at some point.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@70089 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Sema/SemaExpr.cpp | 19 | ||||
| -rw-r--r-- | test/Sema/PR2963-enum-constant.c | 2 |
2 files changed, 13 insertions, 8 deletions
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index e7d5ee18ff..6e86e71bd4 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -4929,6 +4929,13 @@ bool Sema::DiagnoseAssignmentResult(AssignConvertType ConvTy, } bool Sema::VerifyIntegerConstantExpression(const Expr *E, llvm::APSInt *Result){ + llvm::APSInt ICEResult; + if (E->isIntegerConstantExpr(ICEResult, Context)) { + if (Result) + *Result = ICEResult; + return false; + } + Expr::EvalResult EvalResult; if (!E->Evaluate(EvalResult, Context) || !EvalResult.Val.isInt() || @@ -4946,14 +4953,12 @@ bool Sema::VerifyIntegerConstantExpression(const Expr *E, llvm::APSInt *Result){ return true; } - if (EvalResult.Diag) { - Diag(E->getExprLoc(), diag::ext_expr_not_ice) << - E->getSourceRange(); + Diag(E->getExprLoc(), diag::ext_expr_not_ice) << + E->getSourceRange(); - // Print the reason it's not a constant. - if (Diags.getDiagnosticLevel(diag::ext_expr_not_ice) != Diagnostic::Ignored) - Diag(EvalResult.DiagLoc, EvalResult.Diag); - } + if (EvalResult.Diag && + Diags.getDiagnosticLevel(diag::ext_expr_not_ice) != Diagnostic::Ignored) + Diag(EvalResult.DiagLoc, EvalResult.Diag); if (Result) *Result = EvalResult.Val.getInt(); diff --git a/test/Sema/PR2963-enum-constant.c b/test/Sema/PR2963-enum-constant.c index 7a08814815..78f2326dae 100644 --- a/test/Sema/PR2963-enum-constant.c +++ b/test/Sema/PR2963-enum-constant.c @@ -13,5 +13,5 @@ enum enum { - SOME_VALUE= FLOAT_TO_SHORT_FIXED(0.1) + SOME_VALUE= FLOAT_TO_SHORT_FIXED(0.1) // expected-warning{{expression is not integer constant expression}} }; |